[perf]: a couple more micro optimizations #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
commented
Apr 4, 2025
|
|
||
| /// Set all event pipes to `pending`. | ||
| eventPipes.forEach { $0.setPending() } | ||
| for eventPipe in eventPipes { |
There was a problem hiding this comment.
not really a functional change here, but we use for-in everywhere else in this method so we might as well be consistent
| previousSinks = context.sinkStore.usedSinks | ||
|
|
||
| /// Capture all the pipes to be enabled after render completes. | ||
| eventPipes = context.eventPipes | ||
| eventPipes.append(contentsOf: context.sinkStore.eventPipes) | ||
| for (_, sink) in context.sinkStore.usedSinks { |
There was a problem hiding this comment.
previously this was going through a call to map which created an intermediate buffer of the mapped elements. we don't need them to be stored separately so we can just do the iteration inline to avoid that
mjohnson12
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small changes to: