sql: rename Field to Column. #100
Merged
+75
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Field would mean a cell in a row, but our previous Field type is actually a column definition in a schema, so Column is a more previse name.
Current coverage is 61.01% (diff: 94.11%)@@ master #100 diff @@
==========================================
Files 40 40
Lines 1652 1652
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1008 1008
Misses 585 585
Partials 59 59
|
ajnavarro
approved these changes
Jan 27, 2017
dpordomingo
pushed a commit
to dpordomingo/gitbase
that referenced
this pull request
Mar 10, 2017
A Field would mean a cell in a row, but our previous Field type is actually a column definition in a schema, so Column is a more previse name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Field would mean a cell in a row, but our previous
Field type is actually a column definition in a schema,
so Column is a more previse name.