Skip to content

sql: split Catalog API into Databases/FunctionRegistry #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2017
Merged

sql: split Catalog API into Databases/FunctionRegistry #113

merged 1 commit into from
Feb 10, 2017

Conversation

smola
Copy link
Contributor

@smola smola commented Feb 10, 2017

No description provided.

dpordomingo
dpordomingo reviewed Feb 10, 2017
View reviewed changes
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question.
What is the purpose of splitting the Catalog?

@smola
Copy link
Contributor Author

smola commented Feb 10, 2017

@dpordomingo Code for tables catalog and function registry is quite unrelated, so I thought it'd be better to keep them separated with its independent tests. Also, I'm current adding more stuff to the catalog (a TypeCastRegistry in addition to the FunctionRegistry), so I'd implement that independently too.

dpordomingo
dpordomingo approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good idea to separate both since they provide different functionalities

@smola smola merged commit fb17c2f into src-d:master Feb 10, 2017
@smola smola deleted the catalog-api branch February 10, 2017 14:55
dpordomingo pushed a commit to dpordomingo/gitbase that referenced this pull request Mar 10, 2017
@smola
sql: split Catalog API into Databases/FunctionRegistry (src-d#113)
e1c7bc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

@ajnavarro ajnavarro Awaiting requested review from ajnavarro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @dpordomingo