Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aggregate expressions with aliases, fixes #112. #116

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

smola
Copy link
Contributor

@smola smola commented Feb 10, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #116 into master will increase coverage by 0.25%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   60.87%   61.12%   +0.25%     
==========================================
  Files          41       41              
  Lines        1756     1770      +14     
==========================================
+ Hits         1069     1082      +13     
- Misses        622      625       +3     
+ Partials       65       63       -2
Impacted Files Coverage Δ
sql/parse/parse.go 58.85% <100%> (+1.85%)
sql/plan/group_by.go 79.24% <55.55%> (+0.03%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850cf7c...d0b849f. Read the comment docs.

@smola smola merged commit 2a9c67d into src-d:master Feb 10, 2017
@smola smola deleted the fix-count-alias branch February 10, 2017 16:02
dpordomingo pushed a commit to dpordomingo/gitbase that referenced this pull request Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants