Skip to content

update to latest sqle.v0 api (NULL support) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Conversation

smola
Copy link
Contributor

@smola smola commented Apr 21, 2017

  • adapt to latest sqle.v0 api (NULL support)
  • use NULL for target/hash in references table
  • cmd: in pretty printing, print strings quoted
    to distinguish NULL and "NULL"

This PR depends on sqle/sqle#25

* adapt to latest sqle.v0 api (NULL support)
* use NULL for target/hash in references table
* cmd: in pretty printing, print strings quoted
  to distinguish NULL and "NULL"
@smola smola added the enhancement New feature or request label Apr 21, 2017
@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #121 into master will increase coverage by 0.23%.
The diff coverage is 96.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   85.23%   85.46%   +0.23%     
==========================================
  Files          11       11              
  Lines         325      344      +19     
==========================================
+ Hits          277      294      +17     
- Misses         42       44       +2     
  Partials        6        6
Impacted Files Coverage Δ
blobs.go 77.14% <100%> (ø) ⬆️
commits.go 82.97% <100%> (ø) ⬆️
objects.go 77.14% <100%> (ø) ⬆️
internal/format/pretty.go 100% <100%> (ø) ⬆️
tags.go 82.22% <100%> (ø) ⬆️
tree_entries.go 83.33% <100%> (ø) ⬆️
references.go 83.33% <91.66%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba8413...da2b03e. Read the comment docs.

@smola smola merged commit da2b280 into src-d:master Apr 21, 2017
@smola smola deleted the nulls branch April 21, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants