Skip to content

Rename env var GITBASE_UNSTABLE_SQUASH_ENABLE #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcarmonaa
Copy link
Contributor

Closes #249

Signed-off-by: Manuel Carmona [email protected]

Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do this kind of changes, make sure you are changing all the keys on the project doing a full search: https://github.com/src-d/gitbase/blob/8949f5e7858783b6708d552e9566eac6f68b70d3/cli/gitbase/cmd/server.go

Maybe this change is too new and you don't have it in your local git history. Please rebase and modify on all the places.

@mcarmonaa
Copy link
Contributor Author

@ajnavarro done 👍

@mcarmonaa mcarmonaa merged commit f3f8432 into src-d:master Apr 25, 2018
@mcarmonaa mcarmonaa deleted the improvement/rename-unstable-squash-env-var branch April 25, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants