Skip to content

vendor: upgrade go-mysql-server #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2018
Merged

vendor: upgrade go-mysql-server #346

merged 1 commit into from
Jun 29, 2018
+2,373 −193

Conversation

erizocosmico
Copy link
Contributor

Update go-mysql-server with all fixes that have recently been merged.

@erizocosmico erizocosmico requested a review from ajnavarro June 28, 2018 10:44
@ajnavarro
Copy link
Contributor

LGTM after code compiles. OSx is passing but if you check the logs it's throwing an error

@kuba--
Copy link
Contributor

kuba-- commented Jun 28, 2018

Lets rebase and upgrade to the latest version, so it will also fix indexing expressions #238

@ajnavarro
Copy link
Contributor

Yep, also don't forget to update documentation pointing to the same go-mysql-server version.

@erizocosmico
Copy link
Contributor Author

Done @ajnavarro

Perhaps we should open a task to automate the task of updating all that?

@kuba--
Copy link
Contributor

kuba-- commented Jun 28, 2018

We don't want to have order_by/group_by (merged by 08b0ce01897f4ed5a2b45ac32bb87cf335d04dd9)?

@erizocosmico
Copy link
Contributor Author

Yep, I'm gonna upgrade that

@erizocosmico
Copy link
Contributor Author

Done

@erizocosmico
Copy link
Contributor Author

Upgrading to that go-mysql-server broke the tests, fixing.

@erizocosmico
Copy link
Contributor Author

Depends on src-d/go-mysql-server#249

@kuba--
Copy link
Contributor

kuba-- commented Jun 29, 2018

table "commits" does not have column "commit_author_when"

@erizocosmico
Copy link
Contributor Author

Yes, that's why it depends on src-d/go-mysql-server#249 haha

@erizocosmico
Copy link
Contributor Author

Fixed

ajnavarro
ajnavarro reviewed Jun 29, 2018
View reviewed changes
docs/using-gitbase/functions.md Outdated
You can check standard functions in [`go-mysql-server` documentation](https://github.com/src-d/go-mysql-server/tree/08b0ce01897f4ed5a2b45ac32bb87cf335d04dd9#custom-functions).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that hashes are not the same as in Gopkg.toml

ajnavarro
ajnavarro reviewed Jun 29, 2018
View reviewed changes
docs/using-gitbase/supported-syntax.md Outdated
To see the SQL subset currently supported take a look at [this list](https://github.com/src-d/go-mysql-server/blob/08b0ce01897f4ed5a2b45ac32bb87cf335d04dd9/SUPPORTED.md) from [src-d/go-mysql-server](https://github.com/src-d/go-mysql-server).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same.

@ajnavarro
Copy link
Contributor

Now we can use the latest commit with src-d/go-mysql-server#250

@erizocosmico
Copy link
Contributor Author

Yup, upgrading to that version as well

@erizocosmico
vendor: upgrade go-mysql-server
16deddc 
Signed-off-by: Miguel Molina <[email protected]>
@erizocosmico
Copy link
Contributor Author

Done

@ajnavarro ajnavarro merged commit ec22a62 into src-d:master Jun 29, 2018
@erizocosmico erizocosmico mentioned this pull request Jun 29, 2018
Closed
@erizocosmico erizocosmico deleted the upgrade/go-mysql-server-a branch September 18, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erizocosmico @ajnavarro @kuba--