Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support parsing and executing CROSS JOIN #62

Merged
merged 1 commit into from
Nov 18, 2016
Merged

sql: support parsing and executing CROSS JOIN #62

merged 1 commit into from
Nov 18, 2016
+125 −34

Conversation

smola
Copy link
Contributor

@smola smola commented Nov 18, 2016

  • added support to parse CROSS JOIN.
  • improved CROSS JOIN code.
  • added tests for CROSS JOIN with one empty side.
  • added tests for CROSS JOIN parsing and analysis.

@smola
sql: support parsing and executing CROSS JOIN.
35a380a 
* added support to parse CROSS JOIN.
* improved CROSS JOIN code.
* added tests for CROSS JOIN with one empty side.
* added tests for CROSS JOIN parsing and analysis.
@smola smola added the feature label Nov 18, 2016
@smola smola added this to the v0.1.0 milestone Nov 18, 2016
@smola smola changed the title sql: support parsing and executing CROSS JOIN. sql: support parsing and executing CROSS JOIN Nov 18, 2016
@codecov-io
Copy link

codecov-io commented Nov 18, 2016 •
edited
Loading

Current coverage is 53.31% (diff: 75.86%)

Merging #62 into master will increase coverage by 0.27%

@@             master        #62   diff @@
==========================================
  Files            30         30          
  Lines          1133       1146    +13   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            601        611    +10   
- Misses          485        487     +2   
- Partials         47         48     +1

Powered by Codecov. Last update 003dc36...35a380a

@smola smola merged commit f3acb58 into src-d:master Nov 18, 2016
@smola smola deleted the parse-join branch November 18, 2016 15:52
This was referenced Nov 18, 2016
Closed
Closed
dpordomingo pushed a commit to dpordomingo/gitbase that referenced this pull request Mar 10, 2017
@smola
sql: support parsing and executing CROSS JOIN. (src-d#62)
11e752e 
* added support to parse CROSS JOIN.
* improved CROSS JOIN code.
* added tests for CROSS JOIN with one empty side.
* added tests for CROSS JOIN parsing and analysis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smola @codecov-io