Skip to content

Varchar #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Varchar #916

merged 3 commits into from
Jul 5, 2019

Conversation

juanjux
Copy link
Contributor

@juanjux juanjux commented Jul 3, 2019

Fixes #824.

Switch some types to VARCHAR with a size, mostly those of know length or maximum length like hashes (40), entry_modes (16), and emails (254 according to the last RFC). Probably some types like paths, repository_ids and URLS could be switched too, but we should choose a "safe" length for those. One option is to check the length used in git source code; I did that for a couple like the git message length but it used size_t.

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.

Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase, please

@ajnavarro
Copy link
Contributor

@juanjux could you check tests please?

@juanjux
Copy link
Contributor Author

juanjux commented Jul 3, 2019

@ajnavarro I don't know wtf is happening with the Travis build and the TestBuildSquashedTable test because, of course, It Works On My Machine ™️ but I'm investigating.

@juanjux
Copy link
Contributor Author

juanjux commented Jul 4, 2019

Could reproduce the problem by going to the specific directory of the test. Now I just need to understand wtf those numbers differ.

@erizocosmico
Copy link
Contributor

Can you rebase?

Juanjo Alvarez added 2 commits July 4, 2019 14:27
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux
Copy link
Contributor Author

juanjux commented Jul 4, 2019

@erizocosmico fifth rebase done 🥇 the bug in the test should be fixed now @ajnavarro so it should be ready to merge if Travis works.

@juanjux
Copy link
Contributor Author

juanjux commented Jul 4, 2019

Ok, it failed again, daaaamn

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux
Copy link
Contributor Author

juanjux commented Jul 4, 2019

Worked, @ajnavarro can I have a sweet merge?

@ajnavarro
Copy link
Contributor

The schema and docu changed too! well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better types for table columns (VARCHAR instead of TEXT)
4 participants