-
Notifications
You must be signed in to change notification settings - Fork 124
Varchar #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varchar #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase, please
@juanjux could you check tests please? |
@ajnavarro I don't know wtf is happening with the Travis build and the |
Could reproduce the problem by going to the specific directory of the test. Now I just need to understand wtf those numbers differ. |
Can you rebase? |
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@erizocosmico fifth rebase done 🥇 the bug in the test should be fixed now @ajnavarro so it should be ready to merge if Travis works. |
Ok, it failed again, daaaamn |
Signed-off-by: Juanjo Alvarez <[email protected]>
Worked, @ajnavarro can I have a sweet merge? |
The schema and docu changed too! well done! |
Fixes #824.
Switch some types to
VARCHAR
with a size, mostly those of know length or maximum length like hashes (40), entry_modes (16), and emails (254 according to the last RFC). Probably some types like paths, repository_ids and URLS could be switched too, but we should choose a "safe" length for those. One option is to check the length used in git source code; I did that for a couple like the git message length but it usedsize_t
.make upgrade
command if applicable.