Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New nodes #923

Merged
merged 2 commits into from
Jul 8, 2019
Merged

New nodes #923

merged 2 commits into from
Jul 8, 2019

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Jul 8, 2019 •
edited
Loading

Closes #921
closes #869

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.

@erizocosmico
upgrade go-mysql-server
4a925e6 
Signed-off-by: Miguel Molina <[email protected]>
@erizocosmico
update to the new node interfaces
ade8efc 
Signed-off-by: Miguel Molina <[email protected]>
@erizocosmico erizocosmico requested a review from a team July 8, 2019 10:10
@juanjux
Copy link
Contributor

juanjux commented Jul 8, 2019

Bookmarking this because it's great to see how to use the new API side by side with the old one :)

@ajnavarro ajnavarro merged commit d2120e7 into src-d:master Jul 8, 2019
@erizocosmico
Copy link
Contributor Author

erizocosmico commented Jul 8, 2019 •
edited
Loading

@juanjux

TL;DR:

node.TransformUp(fn)

Becomes

plan.TransformUp(node, fn)

Same with all other transforms and expressions.

@erizocosmico erizocosmico deleted the new-nodes branch July 8, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to the new Node API Implement COUNT DISTINCT
4 participants
@erizocosmico @juanjux @ajnavarro @kuba--