cmd: added new output formats #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 61.31% (diff: 100%)@@ master #93 diff @@
==========================================
Files 36 40 +4
Lines 1606 1657 +51
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 965 1016 +51
Misses 582 582
Partials 59 59
|
smola
suggested changes
Jan 13, 2017
| } | ||
| } | ||
|
|
||
| func (cf *CsvFormat) Init(headers []string) error { |
There was a problem hiding this comment.
These method names could look more standard:
Init -> WriteHeader
Line -> Write
End -> Close
| } | ||
|
|
||
| func (cf *JsonFormat) Line(line []interface{}) error { | ||
|
|
| }, | ||
| } | ||
|
|
||
| func TestFormats(t *testing.T) { |
There was a problem hiding this comment.
use separate functions for each format so that we have separate test output for them
Now you can change the output format to 2 new ones: json and csv. - Added json support - Added csv support - Now the table output format is called 'pretty'. It is the default format.
smola
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can change the output format to 2 new ones: json and csv.