sql: make Row a concrete implementation. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smola
commented
Jan 13, 2017
smola
commented
- Row is now a slice instead of an interface.
- MemoryRow is removed.
Current coverage is 61.01% (diff: 65.11%)@@ master #96 diff @@
==========================================
Files 40 40
Lines 1657 1652 -5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1016 1008 -8
- Misses 582 585 +3
Partials 59 59
|
* Row is now a slice instead of an interface. * MemoryRow is removed.
ajnavarro
suggested changes
Jan 13, 2017
| @@ -15,7 +15,7 @@ func NewCount(e sql.Expression) *Count { | |||
| } | |||
|
|
|||
| func (c *Count) NewBuffer() sql.Row { | |||
| return sql.NewMemoryRow(int32(0)) | |||
| return sql.Row{sql.Value(int32(0))} | |||
ajnavarro
approved these changes
Jan 13, 2017
dpordomingo
pushed a commit
to dpordomingo/gitbase
that referenced
this pull request
Mar 10, 2017
* Row is now a slice instead of an interface. * MemoryRow is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.