Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Broken on submodules since .git is not a directory #348

Closed
mvdan opened this issue Apr 18, 2017 · 3 comments
Closed

Broken on submodules since .git is not a directory #348

mvdan opened this issue Apr 18, 2017 · 3 comments
Assignees
@smola
Labels
enhancement

Comments

@mvdan
Copy link
Contributor

mvdan commented Apr 18, 2017

Happens with https://github.com/mvdan/git-picked, which does git.PlainOpen(".") and reads some info about the branches. This software works fine when the clone isn't a submodule.

But when it is...

 $ git-picked
open .git/objects/pack: not a directory

More info:

 $ ls -la .git
-rw-r--r-- 1 mvdan mvdan 34 Mar 27 16:58 .git
 $ cat .git
gitdir: ../.git/modules/webclient
@smola
Copy link
Collaborator

smola commented Apr 26, 2017

@mvdan Thanks for reporting this. We're looking into it.

@smola
Copy link
Collaborator

smola commented Apr 26, 2017

Work in progress: #363

@smola smola self-assigned this Apr 26, 2017
mcuadros added a commit that referenced this issue Apr 27, 2017
@mcuadros
Merge pull request #363 from smola/dotgit-file
bc6b1c4 
add support for .git as file, fixes #348
@mvdan
Copy link
Contributor Author

mvdan commented Apr 27, 2017

Thank you both!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@smola smola

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smola @mvdan