Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

go vet issues #349

Closed
taralx opened this issue Apr 18, 2017 · 2 comments
Closed

go vet issues #349

taralx opened this issue Apr 18, 2017 · 2 comments

Comments

@taralx
Copy link
Contributor

taralx commented Apr 18, 2017

remote.go:44: wrong number of args for format in Sprintf call: 2 needed but 3 args
plumbing/format/packfile/scanner.go:304: method Seek(offset int64) (previous int64, err error) should have signature Seek(int64, int) (int64, error)
plumbing/format/pktline/scanner_test.go:221: Println call ends with newline
plumbing/object/change_adaptor.go:18: no formatting directive in Errorf call
plumbing/object/change_adaptor.go:22: no formatting directive in Errorf call
plumbing/object/change_adaptor.go:55: missing argument for Errorf("%s"): format reads arg 2, have only 1 args
plumbing/object/change_test.go:241: unreachable code
utils/merkletrie/difftree_test.go:123: arg c.Action in printf call is a function value, not a function call
utils/merkletrie/iter_test.go:84: arg t.operations[i] for printf verb %s of wrong type: byte
utils/merkletrie/internal/fsnoder/new.go:37: missing argument for Errorf("%c"): format reads arg 1, have only 0 args

@taralx
Copy link
Contributor Author

taralx commented Apr 18, 2017

(Line numbers reference v4.)

@smola
Copy link
Collaborator

smola commented Apr 26, 2017

Thanks @taralx. We're fixing this and adding go vet to CI: #360

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants