Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

fix go vet issues, add go vet to CI #360

Merged
merged 4 commits into from
Apr 26, 2017
Merged

fix go vet issues, add go vet to CI #360

merged 4 commits into from
Apr 26, 2017

Conversation

smola
Copy link
Collaborator

@smola smola commented Apr 26, 2017 •
edited
Loading

Fixes #349

@smola smola changed the title fix go vet issues, add go vet to CI, fixes #349 fix go vet issues, add go vet to CI Apr 26, 2017
@smola smola mentioned this pull request Apr 26, 2017
Closed
mcuadros
mcuadros suggested changes Apr 26, 2017
View reviewed changes
plumbing/format/packfile/scanner_test.go Outdated
"github.com/src-d/go-git-fixtures"
. "gopkg.in/check.v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mix of internal and external imports

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

ajnavarro
ajnavarro suggested changes Apr 26, 2017
View reviewed changes
plumbing/format/packfile/scanner.go Outdated
@@ -301,7 +301,7 @@ func (s *Scanner) copyObject(w io.Writer) (int64, error) {
}

// Seek sets a new offset from start, returns the old position before the change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You miss to change documentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alcortesm
alcortesm approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@alcortesm alcortesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a very welcome improvement, at last! thanks!

@codecov
Copy link

codecov bot commented Apr 26, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@df8b1cb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage          ?   76.67%           
=========================================
  Files             ?      122           
  Lines             ?     8458           
  Branches          ?        0           
=========================================
  Hits              ?     6485           
  Misses            ?     1261           
  Partials          ?      712
Impacted Files Coverage Δ
plumbing/format/packfile/decoder.go 79.22% <100%> (ø)
utils/merkletrie/internal/fsnoder/new.go 94.73% <100%> (ø)
plumbing/format/packfile/scanner.go 70.58% <100%> (ø)
plumbing/object/change_adaptor.go 100% <100%> (ø)
remote.go 69.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8b1cb...bca4f95. Read the comment docs.

smola added 3 commits April 26, 2017 14:52
@smola
format/packfile: rename Seek to SeekFromStart
250ba29 
This has signature and behavior distinct from io.Seeker,
go vet complains about this, so we change it to a different name
to avoid confusion.
@smola
object: avoid unreachable code
4b5b962
@smola
add go vet to travis
bca4f95
@mcuadros mcuadros merged commit e85778e into src-d:master Apr 26, 2017
@smola smola deleted the go-vet branch May 9, 2017 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcuadros mcuadros mcuadros requested changes

@ajnavarro ajnavarro ajnavarro approved these changes

@alcortesm alcortesm alcortesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smola @ajnavarro @mcuadros @alcortesm