This repository was archived by the owner on Sep 11, 2020. It is now read-only.
CheckClose should be used with named returns #791
Assignees
Labels
Comments
This was referenced Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If
defer CheckClose(closer, &err)is used without named returns any close error is lost. This happens here:https://github.com/src-d/go-git/blob/master/plumbing/format/packfile/common.go#L50
Check if there are any other place where
CheckCloseis not used with a named return.The text was updated successfully, but these errors were encountered: