This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Use CheckClose with named returns and fix tests #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously some close errors were losts. This is specially problematic in go-git as lots of work is done here like generating indexes and moving packfiles. Signed-off-by: Javi Fontan <[email protected]>
Some tests write to an already existent repository retrieved from fixtures. The permissions of these files are read only and make receive pack fail. This was shadowed before as close errors were lost. Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
reviewed
Mar 28, 2018
| @@ -375,7 +375,7 @@ func (d *DotGit) findPackedRefsInFile(f billy.File) ([]*plumbing.Reference, erro | |||
| return refs, s.Err() | |||
| } | |||
|
|
|||
| func (d *DotGit) findPackedRefs() ([]*plumbing.Reference, error) { | |||
| func (d *DotGit) findPackedRefs() (r []*plumbing.Reference, error error) { | |||
There was a problem hiding this comment.
this one is called error instead of err, and you are using err on the code. Is a leftover or am I missing something?
There was a problem hiding this comment.
It's my sloppy fingers, thanks! Just fixed it.
Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
approved these changes
Mar 28, 2018
jfontan
added a commit
to jfontan/old-go-git
that referenced
this pull request
Jun 6, 2018
The cache is used in Tree.FindEntry for faster path search. Signed-off-by: Javi Fontan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously some close errors were losts. This is especially problematic in go-git as lots of work is done here like generating indexes and moving packfiles.
Some tests write to an already existing repository retrieved from fixtures. The permissions of these files are read only and make receive pack fail. This was shadowed before as close errors were lost.
Fixes: #791