This repository was archived by the owner on Sep 11, 2020. It is now read-only.
adds Tree method to Tree #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
approved these changes
Jan 25, 2017
Current coverage is 76.45% (diff: 90.90%)@@ master #224 diff @@
==========================================
Files 98 98
Lines 6360 6370 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4895 4870 -25
- Misses 930 977 +47
+ Partials 535 523 -12
|
smola
suggested changes
Jan 26, 2017
| @@ -48,6 +48,22 @@ func (s *TreeSuite) TestType(c *C) { | |||
| c.Assert(s.Tree.Type(), Equals, plumbing.TreeObject) | |||
| } | |||
|
|
|||
| func (s *TreeSuite) TestTree(c *C) { | |||
There was a problem hiding this comment.
Could you add a test for Tree(path) when path points to a Blob instead of a Tree?
There was a problem hiding this comment.
Good catch.
Fixed in a new commit.
Also add the equivalent test for File, for consistency.
smola
suggested changes
Jan 26, 2017
| @@ -77,7 +77,7 @@ func (t *Tree) File(path string) (*File, error) { | |||
|
|
|||
| blob, err := GetBlob(t.s, e.Hash) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, ErrFileNotFound | |||
There was a problem hiding this comment.
There might be errors other than file not found (such as decoding or network errors). So if err == plumbing.ErrObjectNotFound then ErrFileNotFound, but otherwise just return the error.
| @@ -91,7 +91,12 @@ func (t *Tree) Tree(path string) (*Tree, error) { | |||
| return nil, ErrDirectoryNotFound | |||
| } | |||
|
|
|||
| return GetTree(t.s, e.Hash) | |||
| ret, err := GetTree(t.s, e.Hash) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Same as my previous comment (check the actual error).
smola
approved these changes
Jan 26, 2017
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
This patch adds a new method to the Tree object that allows you to get a child tree from a parent tree by its relative name. Before this patch, this was only possible with files, using the File method. The new Tree method has a similar signature to the old File method for consistency.
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new method to the Tree object that allows you to get a child tree from a parent tree by its relative name.
Before this patch, this was only possible with files, using the
Filemethod.The new
Treemethod has a similar signature to the oldFilemethod for consistency.