This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing/object: move difftree to object package #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajnavarro
commented
Feb 22, 2017
•
ajnavarro
commented
- To avoid cyclic dependency errors, we move all the difftree files to object package.
- Added Diff method to Tree object.
alcortesm
suggested changes
Feb 22, 2017
| @@ -1,11 +1,10 @@ | |||
| package difftree | |||
| package object | |||
There was a problem hiding this comment.
Since you rename the change_adaptor.go file to difftree.go, you should include this tests in difftree_test.go, and rename the suite, otherwise nobody will know what change_adaptor is.
There was a problem hiding this comment.
because change_adaptor_test.go is really huge, y keept the change_adaptor.go file with his original content.
alcortesm
approved these changes
Feb 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 76.93% 77.03% +0.09%
==========================================
Files 116 116
Lines 7900 7902 +2
==========================================
+ Hits 6078 6087 +9
+ Misses 1168 1161 -7
Partials 654 654
Continue to review full report at Codecov.
|
|
@ajnavarro rebase please |
- To avoid ciclic dependency errors, we move all the difftree files to object package. - Added Diff method to Tree object.
|
@mcuadros rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.