This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing/cache: specify units in memory size (Fix #234) #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 116 116
Lines 7902 7902
=======================================
Hits 6087 6087
Misses 1161 1161
Partials 654 654
Continue to review full report at Codecov.
|
mcuadros
approved these changes
Feb 24, 2017
smola
suggested changes
Feb 27, 2017
plumbing/cache/common.go
Outdated
| @@ -3,12 +3,14 @@ package cache | |||
| import "srcd.works/go-git.v4/plumbing" | |||
|
|
|||
| const ( | |||
| Byte = 1 << (iota * 10) | |||
| Byte = FileSize(1 << (iota * 10)) | |||
There was a problem hiding this comment.
Byte FileSize = 1 << (iota * 10) is probably more idiomatic.
smola
approved these changes
Feb 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.