This repository was archived by the owner on Sep 11, 2020. It is now read-only.
git: Repository methods changes #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
+ Coverage 77.19% 77.39% +0.2%
=========================================
Files 117 117
Lines 7937 7986 +49
=========================================
+ Hits 6127 6181 +54
+ Misses 1159 1147 -12
- Partials 651 658 +7
Continue to review full report at Codecov.
|
alcortesm
approved these changes
Mar 2, 2017
ajnavarro
changed the title
|
Why we are removing Tree? |
|
@mcuadros because we talked about this. Get a specific Tree from Porcelain is a little weird, or a list with all the Trees. I can keep these methods if it's necessary. |
smola
suggested changes
Mar 3, 2017
plumbing/storer/reference.go
Outdated
| @@ -28,6 +28,67 @@ type ReferenceIter interface { | |||
| Close() | |||
| } | |||
|
|
|||
| type ReferenceFilteredIter struct { | |||
There was a problem hiding this comment.
let's make this type private.
To have a more consistent public API, we decided to rename some methods, and add others: - Commit method renamed to CommitObject - Commits method renamed to CommitObjects - Tree method renamed to TreeObject - Trees method renamed to TreeObjects - Tags method renamed to TagObjects - Tag method renamed to TagObject - Added method Tags that returns tag references - Added method Branches that returns branch references - Added method Notes that returns note references - Added BlobObject method - Added BlobObjects method Also, we added more functionality related to references: - Added iterator to iterate References with a specific filter Some notes: - #298
smola
approved these changes
Mar 6, 2017
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a more consistent public API, we decided to rename some methods and add others:
Also, we added more functionality related to references:
Some notes: