This repository was archived by the owner on Sep 11, 2020. It is now read-only.
references.go: fix Parents from commit iterator #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 76.65% 77.32% +0.66%
==========================================
Files 122 117 -5
Lines 8439 8017 -422
==========================================
- Hits 6469 6199 -270
+ Misses 1260 1157 -103
+ Partials 710 661 -49
Continue to review full report at Codecov.
|
|
How hard is implement a test for this? |
|
I'll have a look to how to test this. One approximation could be have a correct Commit object that some of his parents doesn't exists into the ObjectStorer. |
|
It should be pretty easy if we mock the ObjectStorer. |
smola
previously approved these changes
Apr 3, 2017
|
You can use an in-memory ObjectStorer for this. |
Avoid a panic when we are iterating parents from a commit. There are more than EOF errors, like Parse errors. Now instead of throw a panic we return the error.
|
@smola @mcuadros @alcortesm Added tests using in-memory ObjectStorer. |
alcortesm
approved these changes
Apr 20, 2017
smola
approved these changes
Apr 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a panic when we are iterating parents from a commit. There are more than EOF errors, like Parse errors. Now instead of throw a panic we return the error.