Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

plumbing: index, Entries converted in a slice of pointers #364

Merged
merged 2 commits into from
May 3, 2017
Merged

plumbing: index, Entries converted in a slice of pointers #364

merged 2 commits into from
May 3, 2017

Conversation

mcuadros
Copy link
Contributor

In order to provide a nicer API, index.Entries was converted to []*Entry

@mcuadros mcuadros requested a review from alcortesm April 26, 2017 18:59
Copy link
Contributor

@alcortesm alcortesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@alcortesm
Copy link
Contributor

alcortesm commented Apr 27, 2017

Now you can simplify worktree_status.go:219-231 a lot, and also make it much more efficient and you no longer has to pass the index to the doUpdateFileToIndex function, as it didn't make any sense, just pass the entry you want to update and the data to update it.

@smola
Copy link
Collaborator

smola commented Apr 27, 2017

Maybe it makes sense to do what @alcortesm proposed in this same PR?

@smola smola closed this Apr 27, 2017
@smola smola reopened this Apr 27, 2017
@codecov
Copy link

codecov bot commented Apr 27, 2017

Codecov Report

Merging #364 into master will decrease coverage by 0.7%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   77.28%   76.58%   -0.71%     
==========================================
  Files         122      122              
  Lines        8518     8519       +1     
==========================================
- Hits         6583     6524      -59     
- Misses       1198     1271      +73     
+ Partials      737      724      -13
Impacted Files Coverage Δ
plumbing/format/index/encoder.go 77.14% <100%> (ø) ⬆️
worktree.go 64.52% <100%> (ø) ⬆️
plumbing/format/index/index.go 26.31% <100%> (ø) ⬆️
plumbing/format/index/decoder.go 67.54% <100%> (ø) ⬆️
utils/merkletrie/index/node.go 93.93% <100%> (+0.39%) ⬆️
worktree_status.go 65.95% <60%> (-1.65%) ⬇️
plumbing/transport/ssh/common.go 0% <0%> (-56.15%) ⬇️
plumbing/transport/ssh/auth_method.go 33.33% <0%> (-24.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cd72d...75c5adf. Read the comment docs.

@mcuadros mcuadros merged commit e727d4d into src-d:master May 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants