Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

do not convert local paths to URL #368

Merged
merged 1 commit into from
May 4, 2017
Merged

do not convert local paths to URL #368

merged 1 commit into from
May 4, 2017

Conversation

smola
Copy link
Collaborator

@smola smola commented Apr 28, 2017

  • Do not convert local paths to URLs, just keep them as they
    are.
  • This way we add support for Windows without taking care of
    Windows path-to-URL conversion.

@smola
Copy link
Collaborator Author

smola commented Apr 28, 2017

It seems it works :)

We used to get a lot of these errors in Windows tests:

----------------------------------------------------------------------
FAIL: references_test.go:291: ReferencesSuite.TestObjectNotFoundError
references_test.go:300:
    c.Assert(err, IsNil)
... value *plumbing.PermanentError = &plumbing.PermanentError{Err:(*url.Error)(0xc043723950)} ("permanent client error: parse file://C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\tmp-tgz-678061493: invalid character \"\\\\\" in host name")

not anymore

* Do not convert local paths to URLs, just keep them as they
  are.
* This way we add support for Windows without taking care of
  Windows path-to-URL conversion.
Copy link
Contributor

@alcortesm alcortesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this.

@mcuadros mcuadros merged commit c00e46e into src-d:master May 4, 2017
mcuadros added a commit that referenced this pull request May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants