This repository was archived by the owner on Sep 11, 2020. It is now read-only.
fix push on git and ssh #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
approved these changes
Jun 12, 2017
ajnavarro
approved these changes
Jun 12, 2017
ajnavarro
suggested changes
Jun 13, 2017
| c.Assert(err, IsNil) | ||
| s.ReceivePackSuite.NonExistentEndpoint = ep | ||
|
|
||
| fmt.Println("BASE", base) |
| @@ -329,10 +333,12 @@ func (s *session) checkNotFoundError() error { | |||
| } | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
just a question, why these strings are variables instead of constants?
There was a problem hiding this comment.
they could actually be constants ;)
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=========================================
- Coverage 77.76% 77.2% -0.57%
=========================================
Files 124 124
Lines 9014 9019 +5
=========================================
- Hits 7010 6963 -47
- Misses 1231 1298 +67
+ Partials 773 758 -15
Continue to review full report at Codecov.
|
* at low level, ReceivePack must close its stream to the server to signal it has finished. * remote.go: Close() must be called on session.
alcortesm
approved these changes
Jun 13, 2017
"ERR access denied or repository not exported:" is now detected as transport.ErrRepositoryNotFound, since that's what git-daemon returns when --informative-errors is not used.
ajnavarro
approved these changes
Jun 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix this issue: #310
Push was getting blocked with
gitandsshtransport because connection was not closed properly.This is fixed in the first commit of the PR. All the others are fixing other issues
that arised while adding code to test the original issue.