This repository was archived by the owner on Sep 11, 2020. It is now read-only.
worktree: Add create and push the blob objects to the storer #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
changed the title
ajnavarro
suggested changes
Jun 19, 2017
worktree_commit.go
Outdated
|
|
||
| _, err = h.s.SetEncodedObject(obj) | ||
| return err | ||
| return |
worktree_status.go
Outdated
| func (w *Worktree) copySymlinkToStorage(path string, fi os.FileInfo) (hash plumbing.Hash, err error) { | ||
| obj := w.r.Storer.NewEncodedObject() | ||
| obj.SetType(plumbing.BlobObject) | ||
| obj.SetSize(fi.Size()) |
There was a problem hiding this comment.
Object creation. Duplicated code.
worktree_status.go
Outdated
| if err != nil { | ||
| return plumbing.ZeroHash, err | ||
| } | ||
|
|
||
| h := plumbing.NewHasher(plumbing.BlobObject, int64(len(target))) | ||
| _, err = h.Write([]byte(target)) | ||
| defer ioutil.CheckClose(writer, &err) |
There was a problem hiding this comment.
duplicated code too in writer and check close.
worktree_status.go
Outdated
| return plumbing.ZeroHash, err | ||
| } | ||
|
|
||
| return w.r.Storer.SetEncodedObject(obj) |
Signed-off-by: Máximo Cuadros <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 77.91% 77.38% -0.53%
==========================================
Files 127 127
Lines 9208 9172 -36
==========================================
- Hits 7174 7098 -76
- Misses 1246 1308 +62
+ Partials 788 766 -22
Continue to review full report at Codecov.
|
alcortesm
approved these changes
Jun 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob creation moved from
Worktree.CommittoWorktree.AddFixes #427