This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport/server: add asClient parameter #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 78.03% 77.42% -0.62%
==========================================
Files 127 127
Lines 9288 9293 +5
==========================================
- Hits 7248 7195 -53
- Misses 1248 1321 +73
+ Partials 792 777 -15
Continue to review full report at Codecov.
|
server.NewClient returns a server that acts as a client. This makes it working seamlessly when registering a server directly with `client.InstallProtocol`.
ajnavarro
approved these changes
Jul 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now server.NewServer takes a second parameter
asClient.When
asClientis true, the returned instance behaves exactlyas a client from any other protocol. This makes it working
seamlessly when registering a server directly with
client.InstallProtocol.