This repository was archived by the owner on Sep 11, 2020. It is now read-only.
*: several windows support fixes #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
force-pushed
the
windows
branch
2 times, most recently
from
e6ff7f6 to
c4d557e
Compare
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 78.05% 78.44% +0.39%
==========================================
Files 127 127
Lines 9376 9715 +339
==========================================
+ Hits 7318 7621 +303
- Misses 1251 1266 +15
- Partials 807 828 +21
Continue to review full report at Codecov.
|
smola
reviewed
Jul 19, 2017
| @@ -388,7 +383,15 @@ func (d *DotGit) rewritePackedRefsWithoutRef(name plumbing.ReferenceName) (err e | |||
| return nil | |||
| } | |||
|
|
|||
| return d.fs.Rename(tmpPath, packedRefsPath) | |||
| if err := f.Close(); err != nil { | |||
There was a problem hiding this comment.
Use CheckClose here for both cases? Otherwise, if closing f fails, tmp is not closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.