Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

move Repository.Pull to Worktree.Pull #499

Merged
merged 1 commit into from
Jul 24, 2017
Merged

move Repository.Pull to Worktree.Pull #499

merged 1 commit into from
Jul 24, 2017

Conversation

mcuadros
Copy link
Contributor

This PR moves the method Pull from the Repository to Worktree, this method should be there because is only useful when the repository is not bare. This is the behavior at cgit:

> git clone git clone [email protected]:git-fixtures/basic.git --bare
....     
> git pull                            
fatal: This operation must be run in a work tree

@@ -43,8 +43,8 @@ func main() {
}

// Pull using the create repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Pull/Fetch

@codecov
Copy link

codecov bot commented Jul 24, 2017

Codecov Report

Merging #499 into master will decrease coverage by 0.51%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   77.99%   77.48%   -0.52%     
==========================================
  Files         127      127              
  Lines        9402     9375      -27     
==========================================
- Hits         7333     7264      -69     
- Misses       1253     1318      +65     
+ Partials      816      793      -23
Impacted Files Coverage Δ
repository.go 74.22% <52.94%> (+0.96%) ⬆️
worktree.go 66.25% <75%> (+0.7%) ⬆️
plumbing/transport/ssh/common.go 2.81% <0%> (-45.08%) ⬇️
plumbing/transport/ssh/auth_method.go 33.33% <0%> (-24.77%) ⬇️
remote.go 72.13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee12ab...460a727. Read the comment docs.

@mcuadros mcuadros merged commit 25a0420 into src-d:master Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants