This repository was archived by the owner on Sep 11, 2020. It is now read-only.
packfile: create packfile.Index and reuse it #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the first PR in a series of 3 to improve performance on various operations, including push. This index structure is required to improve caching and reusing deltas (next 2 PRs). |
5 tasks
|
@smola CI |
ajnavarro
reviewed
Jul 26, 2017
plumbing/format/packfile/decoder.go
Outdated
| func (d *Decoder) Offsets() map[plumbing.Hash]int64 { | ||
| return d.hashToOffset | ||
| // SetIndex sets an index for the packfile. It is recommended to set this. | ||
| // The index might be read from a file or reused from a previous Decoer usage |
plumbing/format/packfile/index.go
Outdated
|
|
||
| // FromIdxFile takes an idxfile.Idxfile and adds its entries to the current | ||
| // index. The current index will be emptied before adding the new entries. | ||
| func (idx *Index) FromIdxFile(idxf *idxfile.Idxfile) { |
There was a problem hiding this comment.
If each Index is only intended to be used on one packfile, Should this method be a constructor?
mcuadros
approved these changes
Jul 26, 2017
There was an internal type (i.e. storage/filesystem.idx) to use as in-memory index for packfiles. This was not convenient to reuse in the packfile. This commit creates a new representation (format/packfile.Index) that can be converted to and from idxfile.Idxfile. A packfile.Index now contains the functionality that was scattered on storage/filesystem.idx and packfile.Decoder's internals. storage/filesystem now reuses packfile.Index instances and this also results in higher cache hit ratios when resolving deltas.
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 78.29% 77.76% -0.54%
==========================================
Files 127 128 +1
Lines 9428 9455 +27
==========================================
- Hits 7382 7353 -29
- Misses 1240 1311 +71
+ Partials 806 791 -15
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an internal type (i.e. storage/filesystem.idx) to
use as in-memory index for packfiles. This was not convenient
to reuse in the packfile.
This commit creates a new representation (format/packfile.Index)
that can be converted to and from idxfile.Idxfile.
A packfile.Index now contains the functionality that was scattered
on storage/filesystem.idx and packfile.Decoder's internals.
storage/filesystem now reuses packfile.Index instances and this
also results in higher cache hit ratios when resolving deltas.