This repository was archived by the owner on Sep 11, 2020. It is now read-only.
cache: reuse object cache for delta resolution, use LRU policy #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ajnavarro
suggested changes
Jul 27, 2017
plumbing/cache/object_lru.go
Outdated
| c.actualSize += objSize | ||
| } | ||
|
|
||
| // Get returns an object by its hash. If the object is not found in the cache. |
There was a problem hiding this comment.
If the object is not found in the cache, what happens?
plumbing/cache/object_lru.go
Outdated
| } | ||
|
|
||
| // Put puts an object into the cache. | ||
| func (c *ObjectLRU) Put(obj plumbing.EncodedObject) { |
There was a problem hiding this comment.
Can you explain more what will happen if the object is already into the cache?
storage/filesystem/object.go
Outdated
| dir *dotgit.DotGit | ||
| index map[plumbing.Hash]*packfile.Index | ||
| } | ||
|
|
||
| func newObjectStorage(dir *dotgit.DotGit) (ObjectStorage, error) { | ||
| s := ObjectStorage{ | ||
| dir: dir, | ||
| DeltaBaseCache: cache.NewObjectLRU(92 * cache.MiByte), |
There was a problem hiding this comment.
can we put the 92 * cache.MiByte as a constant?
* renamed Add to Put * Get returns a second bool value to indicate if there was hit or miss.
Reuse delta base object cache for packfile decoders across multiple instances.
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 78.42% 77.66% -0.77%
==========================================
Files 128 128
Lines 9519 9539 +20
==========================================
- Hits 7465 7408 -57
- Misses 1246 1338 +92
+ Partials 808 793 -15
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.