This repository was archived by the owner on Sep 11, 2020. It is now read-only.
revlist: ignore all objects reachable from ignored objects #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2017
ajnavarro
approved these changes
Jul 27, 2017
mcuadros
suggested changes
Jul 27, 2017
plumbing/revlist/revlist.go
Outdated
| func Objects( | ||
| s storer.EncodedObjectStorer, | ||
| objs []plumbing.Hash, | ||
| ignore []plumbing.Hash) ([]plumbing.Hash, error) { |
There was a problem hiding this comment.
why are you duplicating the types?
There was a problem hiding this comment.
They are not duplicated. The public signature is still the same. However, I moved most of the logic of Objects to a private implementation objects which can be called with further arguments. That one is used from Objects and it's called twice.
Usually we call revlist.Objects ignoring a set of commits. This is not enough to ignore everything reachable from such set, so we first get all objects reachable from the ignored set and then walk the tree again ignoring that new set.
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=========================================
- Coverage 78.29% 77.79% -0.5%
=========================================
Files 128 128
Lines 9540 9528 -12
=========================================
- Hits 7469 7412 -57
- Misses 1264 1322 +58
+ Partials 807 794 -13
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually we call revlist.Objects ignoring a set of commits.
This is not enough to ignore everything reachable from such
set, so we first get all objects reachable from the ignored
set and then walk the tree again ignoring that new set.
Fixes #505