Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

*: windows support, skipped receive_pack_test for git transport #540

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

mcarmonaa
Copy link
Contributor

No description provided.

@mcarmonaa mcarmonaa mentioned this pull request Aug 10, 2017
@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b525e63). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #540   +/-   ##
=========================================
  Coverage          ?   77.52%           
=========================================
  Files             ?      129           
  Lines             ?     9779           
  Branches          ?        0           
=========================================
  Hits              ?     7581           
  Misses            ?     1380           
  Partials          ?      818

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b525e63...7538ff8. Read the comment docs.

@@ -29,6 +30,10 @@ type ReceivePackSuite struct {
var _ = Suite(&ReceivePackSuite{})

func (s *ReceivePackSuite) SetUpTest(c *C) {
if runtime.GOOS == "windows" {
c.Skip("git for windows has issues with write operations through git:// protocol")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the link to the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcuadros done

@mcarmonaa mcarmonaa force-pushed the fix/git-transport-windows-test branch from e8da206 to 7538ff8 Compare August 10, 2017 10:08
@mcuadros mcuadros merged commit ffa72cf into src-d:master Aug 10, 2017
@mcarmonaa mcarmonaa deleted the fix/git-transport-windows-test branch August 18, 2017 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants