This repository was archived by the owner on Sep 11, 2020. It is now read-only.
prevent PackWriter from using Notify if nothing was written #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PackWriter is not used,
Close
will callNotify
even if the index isnil
, which may cause a nil pointer dereference later down the line in the execution inObjectStorage
due to the insertion ofnil
indexes on the index.An alternative fix if this is correct behavior would be to just check for nil indexes here:
go-git/storage/filesystem/object.go
Lines 90 to 92 in 91868d1