This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: use LookPath instead of Stat to fix Windows executables #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strib
force-pushed
the
strib/fix-win-cmd-lookup
branch
from
3eec53c to
af328df
Compare
When git-core isn't in the user's PATH, we need to use `LookPath` to verify the existence of the executable, rather than `os.Stat`, so that on Windows it will search for files with executable suffixes.
strib
force-pushed
the
strib/fix-win-cmd-lookup
branch
from
af328df to
aad08e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
========================================
- Coverage 78% 77.4% -0.6%
========================================
Files 129 129
Lines 9842 9842
========================================
- Hits 7677 7618 -59
- Misses 1327 1399 +72
+ Partials 838 825 -13
Continue to review full report at Codecov.
|
|
@mcuadros @erizocosmico this is ready for review/merge too, if you get the chance. The file transport protocol is currently broken on Windows without this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When git-core isn't in the user's PATH, we need to use
LookPathtoverify the existence of the executable, rather than
os.Stat, so thaton Windows it will search for files with executable suffixes.