Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

dotgit: avoid duplicated references returned by Refs #569

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

erizocosmico
Copy link
Contributor

Refs could have duplicated references due to a race condition checking the mod time of packed-refs. Happened in https://travis-ci.org/src-d/borges/builds/263088460

ModTime returns the exact same time, but the content inside packed-refs is not the same.

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #569 into master will decrease coverage by 0.58%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage      78%   77.41%   -0.59%     
==========================================
  Files         129      129              
  Lines        9851     9855       +4     
==========================================
- Hits         7684     7629      -55     
- Misses       1328     1400      +72     
+ Partials      839      826      -13
Impacted Files Coverage Δ
storage/filesystem/internal/dotgit/dotgit.go 72.03% <78.57%> (+0.43%) ⬆️
plumbing/transport/ssh/common.go 20.54% <0%> (-45.21%) ⬇️
plumbing/transport/ssh/auth_method.go 31.57% <0%> (-22.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa9d15...51e25dd. Read the comment docs.

@mcuadros mcuadros merged commit 3ca3702 into src-d:master Aug 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants