Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

revert: revlist: do not revisit already visited ancestors #584

Merged

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Sep 8, 2017

Looks like the assumption for this optimization was not correct. I don't know why yet but empirically, revlist with this optimisation is different to revlist without it at least on https://github.com/thrasnic/mongoose.

Revlist with optimisation: 29050 objects
Without optimisation: 33916 objects

@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #584 into master will decrease coverage by 0.59%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #584     +/-   ##
=========================================
- Coverage   78.34%   77.74%   -0.6%     
=========================================
  Files         130      130             
  Lines       10097    10092      -5     
=========================================
- Hits         7910     7846     -64     
- Misses       1342     1414     +72     
+ Partials      845      832     -13
Impacted Files Coverage Δ
plumbing/revlist/revlist.go 72.94% <66.66%> (-1.51%) ⬇️
plumbing/transport/ssh/common.go 20.54% <0%> (-45.21%) ⬇️
plumbing/transport/ssh/auth_method.go 31.57% <0%> (-22.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34443b...0debae1. Read the comment docs.

@mcuadros mcuadros merged commit ee959a4 into src-d:master Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants