This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport: made public all the fields and standardized AuthMethod #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
approved these changes
Nov 21, 2017
ajnavarro
suggested changes
Nov 21, 2017
| func (m *baseAuthMethod) hostKeyCallback() (ssh.HostKeyCallback, error) { | ||
| // SetHostKeyCallback sets the field HostKeyCallback in the given cfg. If | ||
| // HostKeyCallback is empty a default callback is created using | ||
| // NewKnownHostsHostKeyCallback. |
There was a problem hiding this comment.
The name of the constructor is not correct.
Signed-off-by: Máximo Cuadros <[email protected]>
ajnavarro
suggested changes
Nov 21, 2017
| @@ -287,17 +292,26 @@ func filterKnownHostsFiles(files ...string) ([]string, error) { | |||
| return out, nil | |||
| } | |||
|
|
|||
| type baseAuthMethod struct { | |||
| // HostKeyCallbackHelper is a helper that provides common functionality to | |||
| // configure HostKeyCallback into a ssh.ClientConfig. | |||
There was a problem hiding this comment.
ssh.ClientConfig should be ssh.HostKeyCallback ?
There was a problem hiding this comment.
the field is called HostKeyCallback inside of the cfg
ajnavarro
approved these changes
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small review on the
AuthMethodat transport, some methods/fields were private making to the user more complex to build custom solutions.Also I standardized AuthMethod constructors and fields, since we had for example
PassandPasswordin http/ssh