This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: object/tag, add signature and verification support #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orirawlings
suggested changes
Nov 24, 2017
plumbing/object/tag.go
Outdated
| signature := strings.NewReader(t.PGPSignature) | ||
|
|
||
| // Remove signature. Keep only the tag components. | ||
| t.PGPSignature = "" |
There was a problem hiding this comment.
I think here and in Commit.Verify we should avoid mutating the object in this method. Maybe we should extract a new method Tag.encode(o plumbing.EncodedObject, includeSig bool) which we can call from here and Tag.Encode with different parameters.
Adds Commit.encode() and Tag.encode() with optional `includeSig` parameter to include or exclude signature from the encoded object.
darkowlzz
force-pushed
the
tag_sign_and_verify
branch
from
fc8c0ca to
e1ce83f
Compare
@orirawlings Sounds good. I've added method |
ferhatelmas
added a commit
to ferhatelmas/go-git
that referenced
this pull request
Nov 24, 2017
orirawlings
approved these changes
Nov 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.