This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: cache, enforce the use of cache in packfile decoder #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoder object can make use of an object cache to speed up processing.
Previously the only way to specify it was changing manually the struct
generated by NewDecodeForFile. This lead to some instances to be created
without it and penalized performance.
Now the cache should be explicitly passed to the constructor function.
NewDecoder now creates objects with a cache using the default size.
A new helper function was added to create cache objects with the default
size as this becomes a common task now:
cache.NewObjectLRUDefault()
Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
suggested changes
Dec 20, 2017
plumbing/format/packfile/decoder.go
Outdated
| // deserialization of all the objects | ||
| // deserialization of all the objects. | ||
| // | ||
| // cacheObject is an ObjectLRU that is used to speed up the process. If cache |
There was a problem hiding this comment.
The cache instance can be any implementation of cache.Object
plumbing/format/packfile/decoder.go
Outdated
| // | ||
| // cacheObject is an ObjectLRU that is used to speed up the process. If cache | ||
| // is not needed you can pass nil. To create a cache object with the default | ||
| // size you an use the helper cache.ObjectLRUDefault(). |
plumbing/format/packfile/decoder.go
Outdated
| o: o, | ||
| s: s, | ||
| o: o, | ||
| DeltaBaseCache: cacheObject, |
There was a problem hiding this comment.
can you make DeltaBaseCache private?
There was a problem hiding this comment.
I've addressed these issues in the following commits.
Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
mcuadros
suggested changes
Dec 20, 2017
| @@ -24,6 +24,11 @@ func NewObjectLRU(maxSize FileSize) *ObjectLRU { | |||
| return &ObjectLRU{MaxSize: maxSize} | |||
| } | |||
|
|
|||
| // NewObjectLRUDefault creates a new ObjectLRU with the default cache size. | |||
| func NewObjectLRUDefault() *ObjectLRU { | |||
There was a problem hiding this comment.
Now cache tests are done twice. One with the previous cache and another time with a cache created with NewObjectLRUDefault.
Signed-off-by: Javi Fontan <[email protected]>
mcuadros
approved these changes
Dec 20, 2017
mcuadros
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoder object can make use of an object cache to speed up processing.
Previously the only way to specify it was changing manually the struct
generated by NewDecodeForFile. This lead to some instances to be created
without it and penalized performance.
Now the cache should be explicitly passed to the constructor function.
NewDecoder now creates objects with a cache using the default size.
A new helper function was added to create cache objects with the default
size as this becomes a common task now: