This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Add a setRef and rewritePackedRefsWhileLocked versions that supports non rw fs #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some filesystems that do not support opening the files in read and write modes at the same time. The method SetRef is split in files with an extra version that only writes the reference. It can be activated with -tags norwfs on building. Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
suggested changes
Dec 21, 2017
|
|
||
| import "gopkg.in/src-d/go-git.v4/plumbing" | ||
|
|
||
| func (d *DotGit) setRef(fileName, content string, old *plumbing.Reference) error { |
There was a problem hiding this comment.
Can you add some comments here explaining the reason of this method (like on the PR description)?
Signed-off-by: Javi Fontan <[email protected]>
|
Do not merge. There are still some changes needed to make it fully compatible. |
jfontan
changed the title
Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
jfontan
changed the title
|
The implementation is ready. Tests also pass with |
mcuadros
approved these changes
Jan 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some filesystems that do not support opening the files in read
and write modes at the same time. The method SetRef is split in files with
an extra version that only writes the reference. It can be activated with
-tags norwfson building.