Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Set default pack window size in config #712

Merged
merged 3 commits into from
Jan 10, 2018
Merged

Set default pack window size in config #712

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b71e65
Set default pack window size in config
jfontan Jan 9, 2018
891459c
Add tests for default config values
jfontan Jan 10, 2018
a4ea96f
Make DefaultPackWindow const public and document it
jfontan Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,15 @@ type Config struct {

// NewConfig returns a new empty Config.
func NewConfig() *Config {
return &Config{
config := &Config{
Remotes: make(map[string]*RemoteConfig),
Submodules: make(map[string]*Submodule),
Raw: format.New(),
}

config.Pack.Window = defaultPackWindow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make defaultPackWindow public and document it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


return config
}

// Validate validates the fields and sets the default values.
Expand Down