This repository was archived by the owner on Sep 11, 2020. It is now read-only.
config: modules, worktree: Submodule fixes for CVE-2018-11235 #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes CVE-2018-11235 References: * https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/ * https://security-tracker.debian.org/tracker/CVE-2018-11235 * git/git@0383bbb Signed-off-by: Joseph Vusich <[email protected]>
References: * https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/ * https://security-tracker.debian.org/tracker/CVE-2018-11235 * git/git@10ecfa7 Signed-off-by: Joseph Vusich <[email protected]>
|
Thanks for the quick patching on this. I'm just starting to use this library and i'm curious: Does go-git support hooks or ever plans to? If someone were to recursively clone a malicious repository using go-git, could code exec have been possible? It'd be nice to be using a git library that doesn't have the surface area of hooks to worry about. There have already been a few code execution exploits that relied on git hooks and when building software to process git repositories, more of them is a concern. |
|
@dustin-decker We do not support hooks and we have no plans to do it. We might consider supporting hooks if someone is willing to contribute it. But I think that, in that case, it would be opt-in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes addressing CVE-2018-11235:
.." in the module path..gitmodulesto be a symlink.Both of these changes mirror fixes made by the canonical Git project in response to the CVE.
References: