Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

sql/analyzer: back-propagate expression names after adding convert #739

Merged
merged 1 commit into from
Jun 4, 2019
Merged

sql/analyzer: back-propagate expression names after adding convert #739

merged 1 commit into from
Jun 4, 2019

Conversation

erizocosmico
Copy link
Contributor

No description provided.

@erizocosmico erizocosmico added the bug Something isn't working label Jun 3, 2019
@erizocosmico erizocosmico requested a review from a team June 3, 2019 13:31
@erizocosmico erizocosmico self-assigned this Jun 3, 2019
@erizocosmico erizocosmico mentioned this pull request Jun 3, 2019
Closed
@ajnavarro
Copy link
Contributor

Shall we avoid add date casts to fields that are already a Date?

@erizocosmico erizocosmico force-pushed the fix/resolve-convert-alias branch from b99763e to 71819b4 Compare June 4, 2019 08:43
@erizocosmico
Copy link
Contributor Author

Fields that are already date are exactly the reason why we added this rule. Data sources may return dates that are outside the valid range for MySQL.

@ajnavarro ajnavarro merged commit 26a0ec9 into src-d:master Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

Assignees

@erizocosmico erizocosmico

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erizocosmico @ajnavarro @kuba--