This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add metrics (engine, analyzer, regex, pilosa) based on go-kit interface. #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjux
reviewed
Jun 4, 2019
erizocosmico
suggested changes
Jun 5, 2019
Signed-off-by: kuba-- <[email protected]>
ajnavarro
approved these changes
Jun 7, 2019
erizocosmico
approved these changes
Jun 11, 2019
juanjux
approved these changes
Jun 11, 2019
|
@kuba-- could you rebase please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- [email protected]
Orchestrate mysql server by metrics based on
go-kitmetrics interface.Generic implementation (to satisfy prometheus, etc.) comes with some constraints (like you cannot reregister the same metric, you cannot reuse constructors, so we cannot pass builders to some kind of registry etc.). So, we ended up with following proposal, where you have to initialize global vars per package.
By default all metrics are based on
discardimplementation which is basicallynoop.