-
Notifications
You must be signed in to change notification settings - Fork 109
Format SHOW PROCESSLIST progress as a tree #861
Conversation
sql/plan/processlist.go
Outdated
progress := proc.Progress[name] | ||
|
||
printer := sql.NewTreePrinter() | ||
printer.WriteNode("\n" + progress.String()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of printer.WriteNode
is not checked (from errcheck
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should _ = printer.WriteNode
sql/plan/processlist.go
Outdated
children = append(children, partitionProgress.String()) | ||
} | ||
sort.Strings(children) | ||
printer.WriteChildren(children...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of printer.WriteChildren
is not checked (from errcheck
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor checks golangci bot is mentioning, LGTM.
Signed-off-by: Carlos <[email protected]>
462f63b
to
e81f029
Compare
GolangCI changes made and squashed |
This is a sugestion by @ajnavarro, related to #855.
With the changes in this PR the output of SHOW PROCESSLIST shows the progress formatted as a tree: