Fix dependency conflict and wrong badge link. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillem Duran <[email protected]>
|
@vmarkovtsev Is this coverage fail my fault? |
vmarkovtsev
changed the title
vmarkovtsev
requested changes
May 9, 2019
Signed-off-by: Guillem Duran <[email protected]>
vmarkovtsev
approved these changes
May 9, 2019
|
Done, now the message is displayed both in setup.py and requirements.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the order of requests and dulwich avoids installing an uncompatible version of urllib3. This happens because requets has a closed interval of valid versions of urllib3 ('urllib3>=1.21.1,<1.25') and dulwich only needs
urllib3[secure]>=1.23. If dulwich is installed before requests. the installed version of urllb3 will be 1.25, and will make requests fail.The project was moved to travis.com from travis.org, so I updated the links of the badge to point to the new url.