-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat!: Add method for pre-configured Tracing instance #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adc7f5d
to
3d44b9e
Compare
8eee302
to
1e95f7e
Compare
24f7201
to
861ded9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a new
Tracing::pre_configured
method which provides a "one-liner" to construct aTracing
instance in operators. See the following example:The
TelemetryOptions
will come directly from the operator CLI arguments. Support for usage viaclap
is provided behind the identically named feature flag instackable-telemetry
.