Skip to content

test(stackable-versioned): Combine snapshot and compile tests #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2025
Merged

test(stackable-versioned): Combine snapshot and compile tests #1041

merged 5 commits into from
May 21, 2025

Conversation

Techassi
Copy link
Member

This PR combines the snapshot tests and compile (trybuild) tests to achieve better test coverage:

  • Producing the code we expect doesn't mean it compiles
  • Previous placeholder functions (like custom conversion and default functions) are now required to exist and be valid
  • Both types of tests now use the same input files

@Techassi Techassi self-assigned this May 20, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering May 20, 2025
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 20, 2025
@Techassi Techassi marked this pull request as ready for review May 20, 2025 13:06
@Techassi Techassi mentioned this pull request May 20, 2025
Open
80 tasks
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 21, 2025
@Techassi Techassi added this pull request to the merge queue May 21, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 21, 2025
Merged via the queue into main with commit 9f021ea May 21, 2025
7 of 8 checks passed
@Techassi Techassi deleted the test/stackable-versioned-combine-tests branch May 21, 2025 09:56
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @sbernauer