Moving command handling to the framework and implement default handling for start, stop and simple restart #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing: - status patch - command completion - a lot more
Updates the requirements on [rstest](https://github.com/la10736/rstest) to permit the latest version. - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [Commits](la10736/rstest@0.10.0...0.11.0) --- updated-dependencies: - dependency-name: rstest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lars Francke <[email protected]>
Due to kube-rs/kube#575 we had to change the where clauses on the owns function, as this doesn't support DynamicTypes anymore. This _should_ not require any changes in the operators themselves, as we don't currently use DynamicTypes. Might break for people who do though.
…e is the current topic under investigation Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
…d of Lars' pr branch. Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
Signed-off-by: Sönke Liebau <[email protected]>
# Conflicts: # Cargo.toml # stackable-operator/src/command_controller.rs # stackable-operator/src/controller.rs # stackable-operator/src/utils.rs
…derive crate Signed-off-by: Sönke Liebau <[email protected]>
This is needed as later commits contain breaking changes that our crates have not yet been adjusted for. Signed-off-by: Sönke Liebau <[email protected]>
…d_refactor # Conflicts: # Cargo.toml # src/command.rs # src/command_controller.rs # src/controller.rs
Signed-off-by: Sönke Liebau <[email protected]>
# Conflicts: # src/error.rs
This was
linked to
issues
Sep 29, 2021
…cts for now. Adapted CHANGELOG.md.
soenkeliebau
commented
Sep 29, 2021
There was a problem hiding this comment.
LGTM overall
We should go through and add some more comments and refactor stuff a bit to make it testabler, as well as add tests, but in the interest of getting this in before the hackathon tomorrow I think we can merge as is for now.
Maybe add a couple of todos before merging..
soenkeliebau
changed the title
maltesander
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds traits and methods to the operator framework which offer convenience methods around command handling.
Finding the currently running command or next command that should be run as well as tracking this in the status is handled by the operator framework.
Additionally Traits have been added which operators can implement for their command objects, this allows some generic handling to be done in the framework, while keeping the flexibility for operators to add their own information to command objects if needed for more complex operations.
Default implementations can be used for start, stop and restart by the operators.
Restart is currently limited in how much of a rolling functionality it offers, as it will still delete all pods before restarting one - but it will delete the pods in a rolling fashion. See #144 for a follow up issue.